On Wed, Aug 9, 2017 at 4:58 PM, Robie Basak <email address hidden>
wrote:
> > [Regression Potential]
> > Low, currently GNOME Flashback is completely unusable on computers with
> a touchscreen.
>
> Is there any possibility that this fix will impact behaviour for users
> on computers without a touchscreen? Please could you consider this
> before performing SRU verification?
>
No, otherwise it would crash for everyone.
For example, the patch says:
>
> ++ if (!settings->monitor_manager)
> ++ return NULL;
>
> Is there any case that settings->monitor_manager might evaluate to false
> on systems without touchscreens?
>
Yes. There is no monitor_manager when object is constructed.
On Wed, Aug 9, 2017 at 4:58 PM, Robie Basak <email address hidden>
wrote:
> > [Regression Potential]
> > Low, currently GNOME Flashback is completely unusable on computers with
> a touchscreen.
>
> Is there any possibility that this fix will impact behaviour for users
> on computers without a touchscreen? Please could you consider this
> before performing SRU verification?
>
No, otherwise it would crash for everyone.
For example, the patch says: >monitor_ manager) >monitor_ manager might evaluate to false
>
> ++ if (!settings-
> ++ return NULL;
>
> Is there any case that settings-
> on systems without touchscreens?
>
Yes. There is no monitor_manager when object is constructed.
--
Alberts Muktupāvels