Ubuntu
gnome-control-center package

  1. Bug #28052
  2. Comment #59

Comment 59 for bug 28052

Revision history for this message
In , Peter Hutterer (peter-hutterer) wrote :

(In reply to comment #39)
> Created an attachment (id=13692) [details]
> patch agaist X server
>

This patch is a bit messy.

CopySwapDeviceAccel() shouldn't even compile due to a stray "e->operation"

SendErrorToClient is not used in current master anymore. just BadMatch directly.

InitDefaultPointerAccelerationScheme(): you could just move the three lines to InitValuatorClassDeviceStruct and just have InitPointerAccelerationScheme. Or move them to the latter and have it as the default action if NULLs are provided.

what also makes me wonder is the high amount of commented lines. if they're not needed, just remove them.

can you fix these things please, then I can have another look at it.