Comment 22 for bug 2039577

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Thanks for updating the patch. The parallel code looks like it will function well.

I would think you could reduce the complexity a little by replacing state_ready_callback with sshd_service_state_ready_callback and sshd_socket_state_ready_callback - that way you can remove some of the branches required to handle multiple cases. You could also just pass CallbackData in all cases and reduce the amount of casting used.

You don't really need the CC_/Cc namespacing prefixes for the new code - it's not used outside this module and existing code generally doesn't put these on.

Neither of the above are blockers, just feedback.