Ubuntu
gnome-control-center package

  1. Bug #2039577
  2. Comment #15

Comment 15 for bug 2039577

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Some general comments on the patch:

There's some code duplication with two implementations of org.freedesktop.systemd1.Manager.GetUnitFileState - this could be shared in a function.

The two services are checked in series, which makes the callback logic somewhat complicated. You should probably check both services in parallel, and only call set_switch_state when the second result is returned.