Comment 25 for bug 197673

Revision history for this message
Florent Mertens (givre) wrote :

> Florent, cool, I'll take a look at your patch tomorrow.

Do as you want. With the actual code i don't see better way to do it.
For now you can't pass objects to g-s-d so you'll always need to store new config in a test file.
BTW, i wonder why they call configuration_apply_stored() via g-s-d and don't call it directly,
that would have been easier to deal with.

> looking at the gnome-desktop changes, they seem to leak file in the case where false is returned in configuration_apply_stored()

Bryce, you might want to use get_filename() in configuration_apply_stored() too.
This avoid hard coding 2 times the name of the conf file, and you get the benefice of idle_free.