Comment 35 for bug 420609

Revision history for this message
In , Digitalfreak (digitalfreak) wrote :

Much has changed since the last patch has been attached therefore it does not apply cleanly now.

For Italian [1] CLDR says that the correct medium date format is "d MMM y" (5 set 1999), correct medium time format is "HH:mm:ss" (13:25:59), correct medium date and time format is "d MMM y, HH:mm:ss" (5 set 1999, 13:25:59).

For Italian in Switzerland [2] it provides the same data although marks them as "unconfirmed".

(In reply to Nicolo' Chieffo from comment #18)
> Ok, so I will change date_fmt to not contain abbreviations.

I've checked some locales and they all contain abbreviations in date_fmt so I think it is perfectly OK to contain abbreviations.

> What about the timezone? Should it be present for both date_fmt and d_fmt?

Most (but not all) of the locales contain the timezone in d_t_fmt but the default C locale does not. Therefore I think it is correct not to include the timezone in d_t_fmt but include it in date_fmt.

Now about the patch:

> * d_t_fmt: "%a %e %b %Y, %T, %Z"
> - remove the leading zero in the day of month using '%e' instead of '%b'

Good idea but I think you'd rather use "%-d" which means "do not pad with zero". "%e" means "pad with space", "%-e" means "do not pad with space" and therefore has the same effect as "%-d". Also, I think that the timezone should be removed.

I will write a new patch and replace it with "%-d" and remove ", %Z".

> - add ',' to separate date, time and timezone

Good, CLDR says that date and time should be separated with a comma.

> * t_fmt: "%H.%M.%S"
> - express the time in the expanded way instead of using '%T', to be sure to
> use the correct values

CLDR says there should be colons rather than dots therefore I will reject this change. Also I will restore the format with colons in date_fmt. "%T" means that "%H:%M:%S" is used literally therefore it is correct.

> * date_fmt: "%c"
> - make date_fmt and d_t_fmt the same

As said above, date_fmt should contain the timezone while d_t_fmt (which is used by "%c") should not. Therefore I think that the correct date_fmt should be "%a %-d %b %Y, %T, %Z" (ven 14 set 2018, 22:07:41, CEST)

Also, I will change d_fmt in it_CH from "%d. %m. %y" (which looks bad) to "%d.%m.%Y" (which is the same as de_CH and is almost the same as CLDR suggests). I will not change d_fmt in it_IT because it looks almost the same as CLDR. (In both cases CLDR suggests two-digit year while we have four digits.)

[1] http://st.unicode.org/cldr-apps/v#/it/Gregorian/
[2] http://st.unicode.org/cldr-apps/v#/it_CH/Gregorian/