Comment 7 for bug 1580376

Revision history for this message
Felix Bünemann (felix-buenemann) wrote :

Martin: I can confirm that the giflib 5.1.4-0.3 packages in xenial-proposed fix the reported problems.

Brian: How would those test cases look like?

Maybe this discussion is helpful:

https://github.com/jcupitt/libvips/issues/437

Running libvips master make test on 5.1.2-0.2 results in:

======================================================================
ERROR: test_gifload (test_foreign.TestForeign)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_foreign.py", line 483, in test_gifload
    self.file_loader("gifload", self.gif_file, gif_valid)
  File "test_foreign.py", line 68, in file_loader
    validate(self, im)
  File "test_foreign.py", line 477, in gif_valid
    a = im(10, 10)
  File "../python/packages/gi/overrides/Vips.py", line 846, in __call__
    return self.getpoint(x, y)
  File "../python/packages/gi/overrides/Vips.py", line 651, in call_function
    return _call_instance(self, name, args, kwargs)
  File "../python/packages/gi/overrides/Vips.py", line 426, in _call_instance
    return _call_base(name, args, kwargs, self)
  File "../python/packages/gi/overrides/Vips.py", line 376, in _call_base
    raise Error('Error calling operator %s.' % name)
Error: Error calling operator getpoint.
  gifload: Failed to read from given file
vips__region_start: start function failed for image images/cramps.gif

======================================================================
ERROR: test_magickload (test_foreign.TestForeign)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_foreign.py", line 331, in test_magickload
    self.file_loader("magickload", self.gif_file, gif_valid)
  File "test_foreign.py", line 70, in file_loader
    validate(self, im)
  File "test_foreign.py", line 321, in gif_valid
    self.assertAlmostEqual(a, [33, 33, 33, 255])
  File "/usr/lib/python2.7/unittest/case.py", line 554, in assertAlmostEqual
    if round(abs(second-first), places) == 0:
TypeError: unsupported operand type(s) for -: 'list' and 'list'

----------------------------------------------------------------------

FAILED (errors=2)
memory: high-water mark 127.03 MB
FAIL test_python.sh (exit status: 1)

============================================================================
Testsuite summary for vips 8.4.0
============================================================================
# TOTAL: 5
# PASS: 4
# SKIP: 0
# XFAIL: 0
# FAIL: 1
# XPASS: 0
# ERROR: 0
============================================================================
See test/test-suite.log
Please report to <email address hidden>
============================================================================

Running libvips master make check on 5.1.4-0.3:

============================================================================
Testsuite summary for vips 8.4.0
============================================================================
# TOTAL: 5
# PASS: 5
# SKIP: 0
# XFAIL: 0
# FAIL: 0
# XPASS: 0
# ERROR: 0
============================================================================