Comment 3 for bug 1955850

Revision history for this message
Matthijs Kooijman (matthijskooijman) wrote :

Hm, that patch is indeed old, that is not consistent with what I thought was going on. So I looked a little closer.

> Looking at the sources, I think this can be traced to:
 - Switching from a custom Xsession file to the upstream Xsession file in 3.38.0-1ubuntu1, combined with
 - An oversight in `debian/patches/ubuntu/xresources_is_a_dir.patch`

It seems the first point is not actually true. The changelog for that version does list "Don't install debian/Xsession", but it is under "Merge with Debian. Remaining changes:", so it's not a new change in that version, just a statement of an existing difference between Ubuntu and Debian. Looking in the current changelog, the earliest version that mentions this change is 3.26.2.1-2ubuntu1 (from 2017), but already as "remaining". I could not find which version introduced this change, but given the age of the patch, I can imagine it has been around since 2011.

In that light, I suspect that the problem I'm seeing is not introduced by switching to upstream Xsession, but by a change in the upstream XSession file that this patch has not been adapted to. And indeed, it's this one: https://gitlab.gnome.org/GNOME/gdm/-/commit/d98debd294060489c77d913d32674c4e08987b8f

But indeed, submitting this patch (after fixing it) upstream is probably a good idea to prevent issues like this in the future (but I don't have the time to take that on).