Comment 4 for bug 1718446

Revision history for this message
Olivier Tilloy (osomon) wrote :

Here is a distro-patch approach that I think is reasonable with the 17.10 final freeze in mind:

 - https://code.launchpad.net/~osomon/gdm/fix-1718446/+merge/332145
 - https://code.launchpad.net/~osomon/gnome-session/fix-1718446/+merge/332146

(the two branches are required for a complete fix).

This is trying to conform to the expectation that fallback sessions have the same desktop file name, which according to Ray (upstream gdm) is how the fallback mechanism is supposed to function.

While testing that approach, I found one minor gotcha: if, with wayland enabled, I intentionally select ubuntu-xorg, then disable wayland, then reboot, in the login screen no session is selected in the dropdown (because gdm ignored ubuntu-xorg). However this will still launch the ubuntu-xorg session by default (which effectively is the same as the ubuntu session), so all is good (except for the fact that no session appears selected in the dropdown). This has the advantage of retaining the "ubuntu-xorg" session selected by the user if wayland is re-enabled later, though.

I didn't get feedback from upstream on that approach yet, although the discussion in the upstream bug report is pointing towards more substantial changes which will require more work and won't be ready in time for 17.10. If we choose to distro-patch I will continue to work on a cleaner solution that can be upstreamed.