incorrect number presentation on gcalctool

[Marcelo Briones]

Binary package hint: gcalctool

I'm using Ubuntu 7.10.

Program gcalctool 5.20.2-0ubuntu1

A number like 123456789 have to be presented as 123.456.789, but the program presents 123,456.789

It's a little thing but can create serious problems if that presentation of the number is pasted in an important document.

A number like 123456789.012 have to be presented as 123.456.789,012 or 123,456,789.012, but the program presents 123,456.789.012 This is very bad!

[Pedro Villavicencio (pedro)]

Thanks for your report, that works fine for me with Hardy gcactool, if you write 123456789 and set the view to "Show Thousands Separator" the number is displayed as 123,456,789 and the other example works fine also. Feel free to re open this report if you still have the issue with latest version of gcalctool available on Hardy, thanks.

[Marcelo Briones (margori)]

I downloaded gcalctool-5.20.2-1ubuntu1.deb from Hardy Heron repositories, and I am afraid this bugs persists.

[Marcelo Briones (margori)]

As additional information, I have my computer configured in Mendoza, Argentina.

[Pedro Villavicencio (pedro)]

Which locale are you using? I've tried to reproduce this with es_AR, es_ES and es_CL and it works fine in all of them.

[Andres S. Paul (anka-ar)]

HI. i'm using es_AR (i'm from argentina). In my case, if i've tried to print 900,000,000.5, setting the view to "Show Thousands Separator" gcalctool print: 900,000.000.5.
Other results are: 1,000 - 1,000.000 - 10,000.000.05 - 900,000.000.000.1

[Marcelo Briones (margori)]

exit of "locale":

LANG=es_AR.UTF-8
LC_CTYPE="es_AR.UTF-8"
LC_NUMERIC="es_AR.UTF-8"
LC_TIME="es_AR.UTF-8"
LC_COLLATE="es_AR.UTF-8"
LC_MONETARY="es_AR.UTF-8"
LC_MESSAGES="es_AR.UTF-8"
LC_PAPER="es_AR.UTF-8"
LC_NAME="es_AR.UTF-8"
LC_ADDRESS="es_AR.UTF-8"
LC_TELEPHONE="es_AR.UTF-8"
LC_MEASUREMENT="es_AR.UTF-8"
LC_IDENTIFICATION="es_AR.UTF-8"
LC_ALL=

[Marcelo Briones (margori)]

I have found the error in the source code. It is the same error in gcalctool 5.20.1 and 5.20.2.

I attach the diff file of display.c

I'm afraid I could not test if this patch works fine or not, so I give you this little work.

(by the way, sorry about my english)

[Marcelo Briones (margori)]

Good news. This is the right patch of this bug. I have tested it, and works!

This patch is applicable into gcalctool 5.20.1 & 5.20.2 because in both packages is the same error.

This is my first contribution as a developer in linux world so I am really exited.

[Pedro Villavicencio (pedro)]

Thanks a lot for your work Marcelo, I've sent this upstream at: http://bugzilla.gnome.org/show_bug.cgi?id=516002 in order to have the review of the gcalctool maintainers, you may want to subscribe to that report also in case they'd have a question on the patch, thanks for your contribution!.

[Pedro Villavicencio (pedro)]

comment from upstream:

"Thanks for the bug report (and patch).
As this is potentially a significant change (and we haven't
heard other similar reports in other locales that use '.' as
the thousands separator), then I think it needs to be investigated
at the start of the next GNOME release cycle, where it can hopefully
be given adequate testing and QA. Therefore we will consider
integrating it some time after March this year."

[klicki (cw-wieschiolek)]

Had exactly the same problem in German:
LANG=de_DE.UTF-8
LANGUAGE=de_DE:de:en_GB:en
LC_CTYPE="de_DE.UTF-8"
LC_NUMERIC="de_DE.UTF-8"
LC_TIME="de_DE.UTF-8"
LC_COLLATE="de_DE.UTF-8"
LC_MONETARY="de_DE.UTF-8"
LC_MESSAGES="de_DE.UTF-8"
LC_PAPER="de_DE.UTF-8"
LC_NAME="de_DE.UTF-8"
LC_ADDRESS="de_DE.UTF-8"
LC_TELEPHONE="de_DE.UTF-8"
LC_MEASUREMENT="de_DE.UTF-8"
LC_IDENTIFICATION="de_DE.UTF-8"
LC_ALL=

[Pedro Villavicencio (pedro)]

fixed upstream now, thanks for your work.