| 2016-11-18 05:09:00 |
Robert Liu |
bug |
|
|
added bug |
| 2016-11-18 05:09:33 |
Robert Liu |
description |
In fwupd, a few of USB devices are not closed when there are some failures of operations. This issue will cause fwupd has some orphan USB nodes inside during fwupd is running. A orphan USB node might introduce memory leak and block some runtime power features as well.
I proposed a upstream, and also put the link here.
https://github.com/hughsie/fwupd/pull/73 |
In fwupd, a few of USB devices are not closed when there are some failures of operations. This issue will cause fwupd has some orphan USB nodes inside during fwupd is running. A orphan USB node might introduce memory leak and block some runtime power features as well.
I proposed a upstream PR, and also put the link here.
https://github.com/hughsie/fwupd/pull/73 |
|
| 2016-11-22 02:14:07 |
Robert Liu |
attachment added |
|
Close-usb-devices-before-error-returns.patch https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1642812/+attachment/4781307/+files/Close-usb-devices-before-error-returns.patch |
|
| 2016-11-22 04:25:22 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2016-11-22 04:25:30 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Review Team |
| 2016-11-23 01:55:17 |
Robert Liu |
attachment added |
|
Close-usb-devices-before-error-returns.patch https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1642812/+attachment/4781812/+files/Close-usb-devices-before-error-returns.patch |
|
| 2016-11-25 08:20:20 |
Shih-Yuan Lee |
bug |
|
|
added subscriber Shih-Yuan Lee |
| 2016-11-28 06:17:59 |
Robert Liu |
attachment added |
|
fwupd_0.7.4-3.debdiff https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1642812/+attachment/4783971/+files/fwupd_0.7.4-3.debdiff |
|
| 2016-11-28 06:18:21 |
Robert Liu |
attachment added |
|
fwupd_0.7.2-0ubuntu2.debdiff https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1642812/+attachment/4783972/+files/fwupd_0.7.2-0ubuntu2.debdiff |
|
| 2016-11-28 06:18:39 |
Robert Liu |
attachment added |
|
fwupd_0.7.0-0ubuntu4.4.debdiff https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1642812/+attachment/4783973/+files/fwupd_0.7.0-0ubuntu4.4.debdiff |
|
| 2017-04-27 08:36:20 |
Robert Liu |
bug |
|
|
added subscriber Ubuntu Sponsors Team |
| 2017-05-07 20:50:41 |
Mathew Hodson |
fwupd (Ubuntu): importance |
Undecided |
Medium |
|
| 2017-05-26 04:14:40 |
Mario Limonciello |
nominated for series |
|
Ubuntu Xenial |
|
| 2017-05-26 04:14:40 |
Mario Limonciello |
bug task added |
|
fwupd (Ubuntu Xenial) |
|
| 2017-05-26 04:14:40 |
Mario Limonciello |
nominated for series |
|
Ubuntu Zesty |
|
| 2017-05-26 04:14:40 |
Mario Limonciello |
bug task added |
|
fwupd (Ubuntu Zesty) |
|
| 2017-05-26 04:14:40 |
Mario Limonciello |
nominated for series |
|
Ubuntu Yakkety |
|
| 2017-05-26 04:14:40 |
Mario Limonciello |
bug task added |
|
fwupd (Ubuntu Yakkety) |
|
| 2017-05-26 04:15:30 |
Mario Limonciello |
fwupd (Ubuntu Zesty): status |
New |
Fix Released |
|
| 2017-05-26 05:01:52 |
Anthony Wong |
bug |
|
|
added subscriber Anthony Wong |
| 2018-01-26 17:01:40 |
Mario Limonciello |
fwupd (Ubuntu Yakkety): status |
New |
Won't Fix |
|
| 2018-01-26 17:01:53 |
Mario Limonciello |
fwupd (Ubuntu): status |
New |
Fix Released |
|
| 2018-02-09 21:12:25 |
Brian Murray |
fwupd (Ubuntu Xenial): status |
New |
Triaged |
|
| 2018-02-09 21:12:31 |
Brian Murray |
fwupd (Ubuntu Xenial): importance |
Undecided |
Medium |
|
| 2018-02-09 21:12:41 |
Brian Murray |
bug |
|
|
added subscriber Brian Murray |
| 2018-02-09 21:13:16 |
Brian Murray |
removed subscriber Ubuntu Review Team |
|
|
|
| 2018-02-12 07:32:14 |
Robert Liu |
description |
In fwupd, a few of USB devices are not closed when there are some failures of operations. This issue will cause fwupd has some orphan USB nodes inside during fwupd is running. A orphan USB node might introduce memory leak and block some runtime power features as well.
I proposed a upstream PR, and also put the link here.
https://github.com/hughsie/fwupd/pull/73 |
[Impact]
* fwupd (used in Xenial) does not close USB device nodes when it fails to process the
devices.
* The orphan (un-closed) device node will be kept until fwupd ends
* The behavior will avoid the system to set the USB device as idle/suspend then the system cannot enter some power-saving mode (eg. S0ix)
[Test Case]
* make sure fwupd is not running by executing 'fwupdmgr get-devices'
It will show devices information.
* list the fds opened by fwupd
$ sudo ls -l /proc/$(pgrep fwupd)/fd | grep usb
If a system is not affected, it will output nothing.
If the result shows one or more strings like /dev/bus/usb/[BUS]/[DEV]
(BUS and DEV are numeric variables), that means the issue is existing.
[Regression Potential]
* The fix only closes file descriptors of USB devices when errors happen and should not have regression there.
[Original description]
In fwupd, a few of USB devices are not closed when there are some failures of
operations. This issue will cause fwupd has some orphan USB nodes inside during fwupd is
running. A orphan USB node might introduce memory leak and block some runtime power
features as well.
I proposed a upstream PR, and also put the link here.
https://github.com/hughsie/fwupd/pull/73 |
|
| 2018-02-12 16:48:28 |
Brian Murray |
fwupd (Ubuntu Xenial): assignee |
|
Brian Murray (brian-murray) |
|
| 2018-02-13 14:54:59 |
Brian Murray |
fwupd (Ubuntu Xenial): status |
Triaged |
Fix Committed |
|
| 2018-02-15 11:21:07 |
Łukasz Zemczak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2018-02-15 11:21:09 |
Łukasz Zemczak |
bug |
|
|
added subscriber SRU Verification |
| 2018-02-15 11:21:13 |
Łukasz Zemczak |
tags |
patch |
patch verification-needed verification-needed-xenial |
|
| 2018-02-15 11:21:36 |
Łukasz Zemczak |
removed subscriber Ubuntu Sponsors Team |
|
|
|
| 2018-02-26 02:27:35 |
Robert Liu |
tags |
patch verification-needed verification-needed-xenial |
patch verification-done-xenial verification-needed |
|
| 2018-03-01 23:52:50 |
Launchpad Janitor |
fwupd (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2018-03-01 23:53:01 |
Brian Murray |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
