USB devices are not closed when error occurs

Bug #1642812 reported by Robert Liu on 2016-11-18
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
fwupd (Ubuntu)
Medium
Unassigned
Xenial
Undecided
Unassigned
Yakkety
Undecided
Unassigned
Zesty
Undecided
Unassigned

Bug Description

In fwupd, a few of USB devices are not closed when there are some failures of operations. This issue will cause fwupd has some orphan USB nodes inside during fwupd is running. A orphan USB node might introduce memory leak and block some runtime power features as well.

I proposed a upstream PR, and also put the link here.
https://github.com/hughsie/fwupd/pull/73

Robert Liu (robertliu) on 2016-11-18
description: updated
Robert Liu (robertliu) wrote :

The upstream PR has been merged.
Could we have this patch also land in Ubuntu, please?

The attachment "Close-usb-devices-before-error-returns.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Robert Liu (robertliu) wrote :

update the patch to fix the compiling error.

Robert Liu (robertliu) wrote :

for Zesty

Robert Liu (robertliu) wrote :

for Yakkety

Robert Liu (robertliu) wrote :

for Xenial

Changed in fwupd (Ubuntu):
importance: Undecided → Medium
Changed in fwupd (Ubuntu Zesty):
status: New → Fix Released
Mario Limonciello (superm1) wrote :

Zesty adopted 0.8.1, this is already fixed there.

Amr Ibrahim (amribrahim1987) wrote :

Ping!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers