The bug description says 'this crash'. But a crash is not demonstrated, only a compiler warning. The code is definitely wrong, as described; and the compiler warning is correct; but this bug report has not demonstrated that this results in a crash.
In fact, the upstream fix that has been proposed for backporting addresses the compiler warning by REMOVING the use of strncmp() in favor of strcmp(), which is less safe, and relying on null termination of the strings!
So this definitely doesn't look to me like something that should be SRUed.
The bug description says 'this crash'. But a crash is not demonstrated, only a compiler warning. The code is definitely wrong, as described; and the compiler warning is correct; but this bug report has not demonstrated that this results in a crash.
In fact, the upstream fix that has been proposed for backporting addresses the compiler warning by REMOVING the use of strncmp() in favor of strcmp(), which is less safe, and relying on null termination of the strings!
So this definitely doesn't look to me like something that should be SRUed.