patches-freetype/fix-incorrect-korean-fonts-rendering.patch appears incorrect
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
freetype (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Trusty |
Triaged
|
High
|
Unassigned |
Bug Description
This is reported in relation to https:/
I have an issue with the patch for FreeType in debian/
but it does not. It applies the above patch, but also runs
src/autofit$ perl ../tools/afblue.pl afblue.dat < afblue.hin > afblue.h
to regenerate the afblue.h. However, it does not also re-generate afblue.c. The re-generation is itself suspect, as this appears to have been run without FreeType commits
991cbcce97527e7
c46fa86bd585639
741f73666247640
6dce136937ab8c4
181fd071ee58b4b
which would bring afblue.pl up to date with this change. (I believe that these commits should be considered a part of a cumulative fix.) It would be nice if afblue.c and afblue.h were generated as part of the build to avoid these sorts of issues, but the initial check-in (8b8be78385a2e5
I would like to request that this patch be re-built to match the FreeType commit. Particularly that after the re-built patch is applied the src/autofit/
git diff trusty:
should have no material differences. I have done this manually, and am attaching a new fix-incorrect-
Changed in freetype (Ubuntu): | |
status: | New → Invalid |
Changed in freetype (Ubuntu Trusty): | |
status: | New → Triaged |
importance: | Undecided → High |
Hi, I'm the author of fix-incorrect- korean- fonts-rendering .patch
As you figured out fix-incorrect- korean- fonts-rendering .patch is not exactly same with 98e510ee94e552e 9e9f80891aa87b2 b472d0f276
And I found out I didn't mention it. My bad.
Due to version difference, the original patch can't applied in Ubuntu's one. 9e9f80891aa87b2 b472d0f276 with afblue.h only regenerated.
If I remember correctly, afblue.h and Changelog diff makes hunk error.
So I regenerated afblue.h only by using afblue.pl in 2.5.2's one, not latest one.
Maybe I didn't regenerate afblue.c because it didn't make hunk error(but maybe warning).
So yes, that file contains only patch of 98e510ee94e552e
I apologize for did it in wrong way.