freetype 2.5.x broke rendering of the default Korean font

[Changwoo Ryu]

* Impact:
The rendering of Ubuntu's default Korean font(NanumGothic) is incorrect.
The most seen sympton is character's upmost part is not shown and it can make impossible to read or confused with different character(ex: 줄 & 출).

* Test case:
Copy and paste '를' to gedit.
Open gucharmap, find 를 (U+B97C), and see character in [Character Details] tab.
Compare it. Upmost horizontal line should apear properly in gedit like as gucharmap's detailed view.

Change account name to '를' and logout.
See account name show properly in greeter.

* Regression potential:
check that text rendering is fine in the greeter and session, using different fonts and locales

-------

ubuntu-settings overrides org.gnome.settings-daemon.plugins.xsettings.hinting to "slight" , while GNOME default was "medium". This broke rendering of NanumGothic, the default font for Korean language, in default installation.

I have no idea on what ground this value has been overridden, but it critically broke Korean language desktop.

screenshots from #1303572

14.04 https://launchpadlibrarian.net/172899667/1404_font.jpg

12.04 https://bugs.launchpad.net/ubuntu/+bug/1303572/+attachment/4084748/+files/1204_font.jpg

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Changwoo Ryu (cwryu)]

Font specific hintstyle settings won't work because of this cairo issue:

https://bugs.freedesktop.org/show_bug.cgi?id=11838

cairo respects this settings more than fontconfig settings.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Jinkyu Yi (jincreator)]

In my opinion, If then this symptom should appears at several releases including precise. But as far I know only trusty is affected.

Precise: gnome-settings-daemon
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/precise/gnome-settings-daemon/precise/view/head:/debian/gnome-settings-daemon.gsettings-override#L1

Quantal: ubuntu-settings
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/quantal/ubuntu-settings/quantal/view/head:/debian/ubuntu-settings.gsettings-override#L71

Raring: ubuntu-settings
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/raring/ubuntu-settings/raring/view/head:/debian/ubuntu-settings.gsettings-override#L86

Saucy: ubuntu-settings
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/saucy/ubuntu-settings/saucy/view/head:/debian/ubuntu-settings.gsettings-override#L93

Trusty: ubuntu-settings
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/trusty/ubuntu-settings/trusty/view/head:/debian/ubuntu-settings.gsettings-override#L99

[Changwoo Ryu (cwryu)]

Freetype 2.5.2 rendering seems to be changed. 13.10 + freetype 2.5.2 installed breaks NanumGothic rendering in the same way.

reported: https://savannah.nongnu.org/bugs/index.php?42148

[Seong-ho Cho (darkcircle-0426)]

Note that Freetype 2.5.3 will also breaks NanumGothic font rendering. (in my experimentation)

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Changwoo Ryu (cwryu)]

Fixed in freetype git

http://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=98e510ee94e552e9e9f80891aa87b2b472d0f276

[Jinkyu Yi (jincreator)]

Dear, Ubuntu SRU & Ubuntu Sponsors team, please take a look and see if this bug can go on SRU process.
This bug doesn't destroy system partition, not causing kernel panic, not a security problem, only Korean users are affected.
However, this is critical to users who read and write Korean characters a lot on Ubuntu.
I know i18n is considered as low priority, but please consider fix this bug and land in Trusty.
Please don't make Korean users leave Ubuntu. Read characters with incorrect rendering for up to 5 years sounds terrible.

p.s This is my first time to request SRU verification. Please let me know if I did something wrong.

[Jinkyu Yi (jincreator)]

The code is at lp:~jincreator/ubuntu/trusty/freetype/lp1310017 and you can easily test by adding ppa:jincreator/freetype

[Somewhere over the.. (nemonein)]

ppa:jincreator/freetype works like a charm.

Great thanks to '이진규'님!

[Brian Murray (brian-murray)]

I've uploaded this to the Trusty proposed queue, however there is an existing Trusty SRU for freetype that will need to get verified first. That is bug 1310728 if you want to speed up the process.

[Launchpad Janitor (janitor)]

This bug was fixed in the package freetype - 2.5.2-1ubuntu4

---------------
freetype (2.5.2-1ubuntu4) utopic; urgency=medium

  * debian/patches-freetype/0002-Fix-Savannah-bug-42418.patch: Cherry-pick
    upstream patch to fix cjk font rendering issue. (LP: #1310017)
 -- Jinkyu Yi <email address hidden> Mon, 05 May 2014 23:26:37 +0900

[Chris Halse Rogers (raof)]

Hello Changwoo, or anyone else affected,

Accepted freetype into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/freetype/2.5.2-1ubuntu2.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[katsu (katsukatsu-deactivatedaccount)]

Ubuntu 14.04-32bit in virtualbox.
fonts-vlgothic(japanese font) package on libreoffice writer.
selected font: VL P gothic

enable trusty-proposed & install package.
$ LANG=C apt-cache policy libfreetype6
libfreetype6:
  Installed: 2.5.2-1ubuntu2.2
  Candidate: 2.5.2-1ubuntu2.2
  Version table:
 *** 2.5.2-1ubuntu2.2 0
        400 http://ubuntu-ashisuto.ubuntulinux.jp/ubuntu/ trusty-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     2.5.2-1ubuntu2.1 0
        500 http://ubuntu-ashisuto.ubuntulinux.jp/ubuntu/ trusty-updates/main i386 Packages
     2.5.2-1ubuntu2 0
        500 http://ubuntu-ashisuto.ubuntulinux.jp/ubuntu/ trusty/main i386 Packages

see: befor_proposed_package.png & after_proposed_package.png

fix the bug.
Please confirm korean fonts is used.

[Jung-Kyu Park (bagjunggyu)]

It fixes the bug , thank you,
please see the screenshot

* libfreetype6 : 2.5.2-1ubuntu2.2

* checked up every korean fonts of ubuntu 14.04 loaded by default and for ubuntu default font

followed the guide line of https://wiki.ubuntu.com/Testing/EnableProposed

* enabling the "trusty-proposed" at the software & update
or
* sudo gedit /etc/apt/preferences

Package: *
Pin: release a=trusty-proposed
Pin-Priority: 400

   sudo apt-get update;sudo apt-get upgrade -s

* sudo apt-get install libfreetype6/trusty-proposed

[Scott Kitterman (kitterman)]

The verification of the Stable Release Update for freetype has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package freetype - 2.5.2-1ubuntu2.2

---------------
freetype (2.5.2-1ubuntu2.2) trusty; urgency=medium

  * Fix incorrect Korean Fonts rendering. (LP: #1310017)
    - debian/patches-freetype/fix-incorrect-korean-fonts-rendering.patch
 -- Jinkyu Yi <email address hidden> Sun, 27 Apr 2014 22:05:39 +0900

[Bungeman (bungeman)]

I have an issue with this patch (fix-incorrect-korean-fonts-rendering.patch). It claims to apply

http://git.savannah.gnu.org/cgit/freetype/freetype2.git/patch/?id=98e510ee94e552e9e9f80891aa87b2b472d0f276

but it does not. It applies the above patch, but also runs

src/autofit$ perl ../tools/afblue.pl afblue.dat < afblue.hin > afblue.h

to regenerate the afblue.h. However, it does not also re-generate afblue.c. The re-generation is itself suspect, as this appears to have been run without FreeType commits

991cbcce97527e74ca3751dd04b89e393420549c
c46fa86bd585639bf4311809ba561675267e99af
741f736662476403cbcac3b9bf0756134f53ce1b
6dce136937ab8c436413ce617ffb5ddb329f3ecc
181fd071ee58b4b59257a2a162ea0a928057aa8d

which would bring afblue.pl up to date with this change. It would be nice if afblue.c and afblue.h were generated as part of the build to avoid these sorts of issues, but the initial check-in (8b8be78385a2e564ebd62983512b81e541dff622) indicates this was not done to avoid a perl build dependency.

I would like to request that this patch be re-built to match the FreeType commit. Particularly that after the re-built patch is applied the src/autofit/afblue.h file look as much like http://git.savannah.gnu.org/cgit/freetype/freetype2.git/plain/src/autofit/afblue.h?id=98e510ee94e552e9e9f80891aa87b2b472d0f276 as possible. Equivalently the output of

git diff trusty:src/autofit/afblue.h 98e510ee94e552e9e9f80891aa87b2b472d0f276:src/autofit/afblue.h

should have no material differences.

[Bungeman (bungeman)]

I have opened https://bugs.launchpad.net/ubuntu/+source/freetype/+bug/1379869 for tracking comment #21, trying to follow the instructions in comment #19.