Comment 22 for bug 2019147

Hi Talha, thanks for addressing the requested changes.

The version field still needs fixing. Check the examples in https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging. The idea here is to avoid upgrade path issues. For instance, by keeping the same versions in jammy and kinetic, a user upgrading from jammy to kinetic would not get his freeipmi package upgraded since the version in the new series would not be greater.

You want to change those string to the following versions:

lunar: 1.6.10-1ubuntu0.1
kinetic: 1.6.9-2ubuntu0.22.10.1
jammy: 1.6.9-2ubuntu0.22.04.1

It would also be nice to adjust the changelog message to set it to an imperative form to match other messages in the changelog.

* d/p/add-initial-support-for-xilinx.patch: support Xilinx (LP: #2015825)

Still for the changelog, I just realized that the reference in there points to a different (private) bug. Instead, you want to refer to this bug, with the SRU template.

* d/p/add-initial-support-for-xilinx.patch: support Xilinx (LP: #2019147)

In https://wiki.ubuntu.com/StableReleaseUpdates, you will find:

"Also make sure that [...] There is a reference to the SRU bug number in the changelog, using the 'LP: #NNNNNN' convention. Only public bugs should be referenced in the changelog."

Finally, you could have kept the commit message in the patch files, which would add more context to the patches. Then, you could add the remaining DE3 headers after that description. This is just a nitpick, no need to change that though.

Overall, the changes LGTM.

I also pushed them to a PPA to ensure the builds are sane in all supported platforms: https://launchpad.net/~athos-ribeiro/+archive/ubuntu/freeipmi-xilinx/+packages.

Next time, it would be nice to do the same to show the sponsors you checked those builds.

Thank you!