Comment 3 for bug 381719

Andres,

After working on this bug myself I would like to take this opportunity to raise a few concerns about the flatnuke upgrade.

The first and biggest concern I have is did you test install, test remove and test purge flatnuke on a karmic system? This must be done to ensure that flatnuke does not leave a users system in a failed state. These are thing we as developers must do.

When you build your package do you test the package with lintian? If not please consider using it. It can give you a wealth of information about packaging mistakes. It checks your packages to make sure it conforms to policy.

I see very few changes in your debdiff that affect the debian directory. You should take this opportunity to get the package in the best shape possible, since this package in not in debian.

You should check very carefully debian/dirs and debian/install for any addition or deletion of files or directories, there are a number that have changed.

You should add the GPL-2 preamble to debian/copyright

Lintian will probably complain of the debhelper version being to old. Consider bumping the debian/control Build-Depends section to debhelper (>=7).

You will also have to set debian/compat to 7

Consider bumping debian/control Standards-Version to 3.8.1

Lintian will also complain of wrong file permissions, I would consider adding this to debian/rules

 dh_install
   find ../ -type d -exec chmod 755 {} \;
   find ../ -type f -exec chmod 644 {} \;

You will also need to flip the build arch section of debian/rules to look something like this

# Build architecture-dependent files here.
binary-arch: build install
# We have nothing to do by default.

# Build architecture-independent files here.
binary-indep: build install

Lintian will probably complain of the installation of empty files and directories. Please check to see if these empty files are needed for flatnuke generated content. In this case they are allowed by policy. If they are needed then consider adding a lintian override.

These are all I can find at the moments. I'm sure once MOTU takes a look there will be others.

Best regards
Charlie Smotherman