Comment 4 for bug 2037407

Revision history for this message
Andreas Hasenack (ahasenack) wrote (last edit ):

Sorry, I have no idea how this package works, so I can't review the code changes properly, only the syntax of the patch.

This should be reviewed by someone familiar with u-boot, so I'm subscribing Dave Jones to this bug, as he has uploaded this package before.

devel_0.debdiff:
- d/changelog needs to be updated for noble (3.107ubuntu3, and noble release name) Maybe the whole patch could be rebased, as there is an offset in db/all.db
- there is no indication from where these changes are coming from. I know this is a native package, but if there is some upstream repository with PRs and comments about these changes, could they be linked somewhere perhaps? But this is just me asking as someone who is not familiar at all with this package.
- the d/changelog diff is also making changes elsewhere in the file, not just adding an entry on top. That is usually not desirable:
@@ -614,7 +620,7 @@

   * Add riscv64 support (LP: #1966219)
   * Add the following boards to db/all.db
- - SiFive HiFive Unmatched A00
+ - SiFive HiFive Unmatched A00
     - BeagleV Starlight Beta

  -- Heinrich Schuchardt <email address hidden> Tue, 08 Mar 2022 10:05:15 +0100

The other debdiffs also have that stray changelog change.

We will also need a mantic diff, now that noble is open for development already.

You should update the [test case] with what you said in the [regression potential] section, about testing other affected boards.