Ubuntu
firefox package

  1. Bug #931637
  2. Comment #67

Comment 67 for bug 931637

Revision history for this message
In , R-luke-h (r-luke-h) wrote :

Comment on attachment 632053
Workaround which only affects DEBUG builds

Review of attachment 632053:
-----------------------------------------------------------------

::: js/public/Vector.h
@@ +565,5 @@
> STATIC_POSTCONDITION(!return || newCap >= curLength + lengthInc)
> +#ifdef DEBUG
> +// By making this method not inline for debug builds, it sidesteps
> +// the compiler generating incorrect code. See bug 694594.
> +JS_NEVER_INLINE bool

Surrounding comments use /* */. Also, I think you could say, more succinctly:

/* ARM compiler bug workaround, see bug 694594. */