(In reply to desrt from comment #16)
> There is really no good reason for this code to exist anymore. I ended up
> with libgnome installed as a dependency for another old program and my
> Firefox install started misbehaving as a (nearly untracable) sideeffect of
> that. It took me quite a while to figure out that a Firefox bug could be
> triggered as a result of installing an unrelated program.
>
> The fact that I didn't have libgnome installed before, and everything was
> working just fine, is as much of an indication as any that this code needs
> to die.
I think this is explained by bug #557601 comment #8 - firefox blocks shutdown for important asynchronous events when you ask it to quit, but not when the session manager asks. I don't think attachment 608321 addresses this any better than the current code does, so a fix is needed for bug #557601 in any case.
I hope someone with more knowledge of asynchronous shutdown can tell whether my analysis is correct and can point to the best way to fix this.
(In reply to desrt from comment #16)
> There is really no good reason for this code to exist anymore. I ended up
> with libgnome installed as a dependency for another old program and my
> Firefox install started misbehaving as a (nearly untracable) sideeffect of
> that. It took me quite a while to figure out that a Firefox bug could be
> triggered as a result of installing an unrelated program.
>
> The fact that I didn't have libgnome installed before, and everything was
> working just fine, is as much of an indication as any that this code needs
> to die.
I think this is explained by bug #557601 comment #8 - firefox blocks shutdown for important asynchronous events when you ask it to quit, but not when the session manager asks. I don't think attachment 608321 addresses this any better than the current code does, so a fix is needed for bug #557601 in any case.
I hope someone with more knowledge of asynchronous shutdown can tell whether my analysis is correct and can point to the best way to fix this.