(In reply to Neil Deakin from comment #3)
> Comment on attachment 553868
> stop making the close button focusable
>
> Is this reverting back 462289 or is that fixed in some other way?
It's still there, I'm only folding the three handlers with button="0"/"1"/"2" into one.
> What effect does removing stopPropagation have here?
It was needed to prevent the tab getting focused when clicking the close button, pre-bug 462289. Maintaining that branch now would regress bug 462289, since we wouldn't set MozUserFocus = 'ignore' in that case.
(In reply to Neil Deakin from comment #3)
> Comment on attachment 553868
> stop making the close button focusable
>
> Is this reverting back 462289 or is that fixed in some other way?
It's still there, I'm only folding the three handlers with button="0"/"1"/"2" into one.
> What effect does removing stopPropagation have here?
It was needed to prevent the tab getting focused when clicking the close button, pre-bug 462289. Maintaining that branch now would regress bug 462289, since we wouldn't set MozUserFocus = 'ignore' in that case.