> What would be the correct way of persisting @charset rules? Extract the
> @charset and write the stream with that encoding?
Yes. For perfect fidelity, we'd have sheets know what charset they were parsed as, and serialize as that charset, modifying or inserting @charset rules as needed. That's what we do for documents...
> Er, because WriteString requires a boolean out param
How about calling the stack boolean "ignored" then? Or warning if it's false? Or something?
> In essence, it boils down to webbrowserpersist expecting to do two passes, and
> to download files before determining the filename to replace the URI with,
Yes, that's the right way to go about it.
I doubt I'll be able to review this any time soon. I definitely won't spend time reviewing until we have tests that this passes, but even then I really doubt that I'll be able to do it within a reasonable timeframe (measured in months).
> Done, though I had Serialize on nsICSSRule
Yeah, that's what I meant.
> What would be the correct way of persisting @charset rules? Extract the
> @charset and write the stream with that encoding?
Yes. For perfect fidelity, we'd have sheets know what charset they were parsed as, and serialize as that charset, modifying or inserting @charset rules as needed. That's what we do for documents...
> Er, because WriteString requires a boolean out param
How about calling the stack boolean "ignored" then? Or warning if it's false? Or something?
> In essence, it boils down to webbrowserpersist expecting to do two passes, and
> to download files before determining the filename to replace the URI with,
Yes, that's the right way to go about it.
I doubt I'll be able to review this any time soon. I definitely won't spend time reviewing until we have tests that this passes, but even then I really doubt that I'll be able to do it within a reasonable timeframe (measured in months).