Comment on attachment 603628 602836: Implement wake lock interface v3.1
Review of attachment 603628: -----------------------------------------------------------------
::: dom/base/Navigator.cpp @@ +974,4 @@ > } > > + nsCOMPtr<nsIDOMMozPowerManager> power = > + do_QueryInterface(NS_ISUPPORTS_CAST(nsIDOMMozPowerManager*, mPowerManager));
What kind of nonsense is this?
nsCOMPtr<nsIDOMMozPowerManager> power = mPowerManager;
will do.
::: dom/power/PowerManagerService.cpp @@ +163,5 @@ > + nsresult rv = wakelock->Init(aTopic, aWindow); > + NS_ENSURE_SUCCESS(rv, rv); > + > + nsCOMPtr<nsIDOMMozWakeLock> wl = > + do_QueryInterface(NS_ISUPPORTS_CAST(nsIDOMMozWakeLock*, wakelock));
As it would here.
Comment on attachment 603628
602836: Implement wake lock interface v3.1
Review of attachment 603628: ------- ------- ------- ------- ------- ------- ------- ------- --
-------
::: dom/base/ Navigator. cpp nsIDOMMozPowerM anager> power = ce(NS_ISUPPORTS _CAST(nsIDOMMoz PowerManager* , mPowerManager));
@@ +974,4 @@
> }
>
> + nsCOMPtr<
> + do_QueryInterfa
What kind of nonsense is this?
nsCOMPtr< nsIDOMMozPowerM anager> power = mPowerManager;
will do.
::: dom/power/ PowerManagerSer vice.cpp >Init(aTopic, aWindow); SUCCESS( rv, rv); nsIDOMMozWakeLo ck> wl = ce(NS_ISUPPORTS _CAST(nsIDOMMoz WakeLock* , wakelock));
@@ +163,5 @@
> + nsresult rv = wakelock-
> + NS_ENSURE_
> +
> + nsCOMPtr<
> + do_QueryInterfa
As it would here.