Ubuntu
firefox package

  1. Bug #602877
  2. Comment #18

Comment 18 for bug 602877

Revision history for this message
In , Marco-zehe (marco-zehe) wrote :

(From update of attachment 441434)
A few comments:
>+ /* Now that selection is done, move the focus to the selection. */
 For single-line comments, please use // comment style.

>+ nsIDOMElement* aElement;
>+ fm->MoveFocus(window, nsnull, nsIFocusManager::MOVEFOCUS_CARET, 0, &aElement);

This is a local variable, not a parameter passed into this function. Therefore, it should not be aElement.

Requesting review from Surkov, but leaving review request for Neil Deakin intact for now for correct focusManager usage.