* you have some unchecked memory allocations that should be handled.
* there a few unprotected printfs - wrap with DEBUG_* or remove.
* since you're treating startOffset differently, nsSVGTextPathFrame::Init
can be modified to remove the startOffset chunk and just request it from
the content in GetStartOffset iff that attribute is set.
* looks like GetStartOffset could use GetPathScale.
* maybe modify the signature of SetGlyphPosition to take a gfxPoint&
instead of moving data in and out of that structure?
A few comments:
* you have some unchecked memory allocations that should be handled.
* there a few unprotected printfs - wrap with DEBUG_* or remove.
* since you're treating startOffset differently, nsSVGTextPathFr ame::Init
can be modified to remove the startOffset chunk and just request it from
the content in GetStartOffset iff that attribute is set.
* looks like GetStartOffset could use GetPathScale.
* maybe modify the signature of SetGlyphPosition to take a gfxPoint&
instead of moving data in and out of that structure?