+ // The following methods must only be called on the main
+ // thread.
Use ***** or something to make these bracketing comments stand out.
+ PRBool mPaused;
+
+ // True if the first frame of data has been loaded. This member,
+ // along with the condition variable and lock is used by threads
+ // that need to wait for the first frame to be loaded before
+ // performing some action. In particular it is used for 'autoplay' to
+ // start playback on loading of the first frame.
+ PRBool mFirstFrameLoaded;
PRPackedBool (and you needn't bother with bitfields, that's a bit more code)
But I think we go for a real review now. I think I can be the reviewer of record for the video and layout parts, and say ... Jonas ... for the content parts.
+ // The following methods must only be called on the main
+ // thread.
Use ***** or something to make these bracketing comments stand out.
+ PRBool mPaused;
+
+ // True if the first frame of data has been loaded. This member,
+ // along with the condition variable and lock is used by threads
+ // that need to wait for the first frame to be loaded before
+ // performing some action. In particular it is used for 'autoplay' to
+ // start playback on loading of the first frame.
+ PRBool mFirstFrameLoaded;
PRPackedBool (and you needn't bother with bitfields, that's a bit more code)
But I think we go for a real review now. I think I can be the reviewer of record for the video and layout parts, and say ... Jonas ... for the content parts.