Comment on attachment 713377 Store Master Password by using libsecret to Gnome Keyring patch v1
Review of attachment 713377: -----------------------------------------------------------------
::: security/manager/ssl/src/nsNSSCallbacks.cpp @@ +800,5 @@ > + rv = profileDir->GetNativeLeafName(profileName); > + if (rv != NS_OK) > + return; > + nsCString keyDescription; > + keyDescription.Assign(MOZ_APP_NAME);
You don't want to use MOZ_APP_NAME here. Use nsIXULAppInfo data.
Comment on attachment 713377
Store Master Password by using libsecret to Gnome Keyring patch v1
Review of attachment 713377: ------- ------- ------- ------- ------- ------- ------- ------- --
-------
::: security/ manager/ ssl/src/ nsNSSCallbacks. cpp >GetNativeLeafN ame(profileName ); Assign( MOZ_APP_ NAME);
@@ +800,5 @@
> + rv = profileDir-
> + if (rv != NS_OK)
> + return;
> + nsCString keyDescription;
> + keyDescription.
You don't want to use MOZ_APP_NAME here. Use nsIXULAppInfo data.