+ *right = *left += focus_width + focus_pad + child_spacing; + *bottom = *top += focus_width + focus_pad + child_spacing;
I don't like mixing assignment types in the same statement ... make these separate statements.
+ *right = *left += gButtonWidget->style->xthickness; + *bottom = *top += gButtonWidget->style->ythickness;
ditto
+ *right = *left += (focus_width + focus_pad); + *bottom = *top += (focus_width + focus_pad);
Otherwise looks good.
It's too late for a change like this to get into alpha5. We could check a revised patch into alpha6 though.
BTW can you verify that printing/print preview still work with this patch?
+ *right = *left += focus_width + focus_pad + child_spacing;
+ *bottom = *top += focus_width + focus_pad + child_spacing;
I don't like mixing assignment types in the same statement ... make these separate statements.
+ *right = *left += gButtonWidget- >style- >xthickness; >style- >ythickness;
+ *bottom = *top += gButtonWidget-
ditto
+ *right = *left += (focus_width + focus_pad);
+ *bottom = *top += (focus_width + focus_pad);
ditto
Otherwise looks good.
It's too late for a change like this to get into alpha5. We could check a revised patch into alpha6 though.
BTW can you verify that printing/print preview still work with this patch?