I fixed the reftest with kaze and volkmar help. We came to a better solution:
make the test and the reference exactly similar except the reference will have spellcheck=false. Then, there's no need anymore to blur the editor.
I also modified another thing since last patch:
> > Then can we just not attempt to do a spell check in that case?
>
> Good idea. In attached patch, I return early from
> mozInlineSpellChecker::ResumeCheck if there is not dictionary available.
>
Actually, I also need to cleanup previously underline words, by calling RemoveRange. Otherwise, a word may stay underlined, even if editor has changed @lang to a unknown one.
That case is coved by test-3
Created attachment 552655
patch v2.7
I fixed the reftest with kaze and volkmar help. We came to a better solution:
make the test and the reference exactly similar except the reference will have spellcheck=false. Then, there's no need anymore to blur the editor.
I also modified another thing since last patch:
> > Then can we just not attempt to do a spell check in that case? hecker: :ResumeCheck if there is not dictionary available.
>
> Good idea. In attached patch, I return early from
> mozInlineSpellC
>
Actually, I also need to cleanup previously underline words, by calling RemoveRange. Otherwise, a word may stay underlined, even if editor has changed @lang to a unknown one.
That case is coved by test-3
I've tested attached patch on tryserver, and it looks like it's correct: tbpl.mozilla. org/?tree= Try&rev= 3adb6f0528ac
http://