(In reply to Ehsan Akhgari [:ehsan] from comment #105) > Comment on attachment 553143 > part2: do not override manually set dictionary > > >+ PRBool mUpdateDictionaryRunning; > >+ PRBool mDictWasSetManually; > > Please use PRPackedBool. > > >+class UpdateDictionnaryHolder { > >+ private: > >+ nsEditorSpellCheck* mSpellCheck; > >+ public: > >+ UpdateDictionnaryHolder(nsEditorSpellCheck* esc): mSpellCheck(esc) { > >+ if (mSpellCheck) { > >+ mSpellCheck->BeginUpdateDictionary(); > >+ } > >+ } > >+ ~UpdateDictionnaryHolder() { > >+ if (mSpellCheck) { > >+ mSpellCheck->EndUpdateDictionary(); > >+ } > >+ } > > }; > > Also, please move this class to the cpp file.
Patch fixes those 2 stuffs.
(In reply to Ehsan Akhgari [:ehsan] from comment #105) ryRunning; ally; ryHolder { ryHolder( nsEditorSpellCh eck* esc): mSpellCheck(esc) { >BeginUpdateDic tionary( ); aryHolder( ) { >EndUpdateDicti onary() ;
> Comment on attachment 553143
> part2: do not override manually set dictionary
>
> >+ PRBool mUpdateDictiona
> >+ PRBool mDictWasSetManu
>
> Please use PRPackedBool.
>
> >+class UpdateDictionna
> >+ private:
> >+ nsEditorSpellCheck* mSpellCheck;
> >+ public:
> >+ UpdateDictionna
> >+ if (mSpellCheck) {
> >+ mSpellCheck-
> >+ }
> >+ }
> >+ ~UpdateDictionn
> >+ if (mSpellCheck) {
> >+ mSpellCheck-
> >+ }
> >+ }
> > };
>
> Also, please move this class to the cpp file.
Patch fixes those 2 stuffs.