Ubuntu
firefox package

  1. Bug #24689
  2. Comment #97

Comment 97 for bug 24689

Revision history for this message
In , Roc-ocallahan (roc-ocallahan) wrote :

(From update of attachment 298171)
+ /**
+ * We call this function so that anything that requires a run of the event loop
+ * can do so safely. The print dialog runs the event loop but in silent printing
+ * that doesn't happen.
+ */

Please document that either SetupSilentPrinting or ShowPrintDialog (but not both) must be called by the print engine when actually printing.

+ // XXX Some platforms allow the user to change the ShrinkToFit option so change it here too

How about
"// The user might have changed shrink-to-fit in the print dialog, so update our copy of its state"
(shouldn't be XXX since there is not a known probem with this)