Comment 24 for bug 241937

Comment on attachment 8902388
Bug 450915 - Increase the drag space of the TabsToolbar by 15px on the bottom to improve the tab reordering experience.

https://reviewboard.mozilla.org/r/173956/#review182276

r+ with the downloads and home button included. We can followup making the 20px match the navbar height more exactly, and/or dealing with the menubar.

::: browser/base/content/browser.css:184
(Diff revision 2)
> .tabbrowser-tabs[movingtab] > .tabbrowser-tab[fadein]:not([selected]) {
> transition: transform 200ms var(--animation-easing-function);
> }
>
> +#TabsToolbar[movingtab] > .tabbrowser-tabs {
> + padding-bottom: 20px;

Clever. Two questions:

- the 20px feels kind of arbitrary. I guess this should basically be the navbar height, right? Is there some way we can more closely approximate this?
- should we also do the same for the top and the menubar, if the menubar is permanently visible (so on non-osx) ?

::: browser/base/content/browser.css:193
(Diff revision 2)
> + margin-top: -20px;
> + pointer-events: none;
> +}
> +
> +/* Allow dropping a tab on the bookmarks-menu-button to create a bookmark. */
> +#TabsToolbar[movingtab] + #nav-bar > #nav-bar-customization-target > #bookmarks-menu-button {

We should do the same for the downloads and the home button, which both also do reasonable things if dropping tabs on them.

::: browser/themes/shared/tabs.inc.css:29
(Diff revision 2)
> :root:-moz-lwtheme {
> --tab-line-color: var(--lwt-accent-color);
> }
>
> #tabbrowser-tabs,
> +#tabbrowser-tabs > .tabbrowser-arrowscrollbox,

Just for my (& future) understanding, why was this necessary?