Comment 135 for bug 19250

Revision history for this message
In , Ian-hixie (ian-hixie) wrote :


 (
) shouldn't do anything special. Since this patch is converting some
control characters to U+FFFD, it should do the same with U+000D.

Only U+000A inserted by character entity should become a line break.

I still don't understand why we're doing the control code conversion thing, nor
do I understand how it is being done, or why only a subset of UNICODE control
characters is being converted. Why is that special cased at all? Shouldn't the
existing code in layout or GFX take care of this?

In any case, if DOM/JS uses UTF-16, isn't the following:

   label.replace(/[\x00-\x08]|[\x0B\x0C]|[\x0E-\x1F]/g, "\uFFFD");

...going to completely corrupt the output? I really don't understand that part
of the code to be honest.

Similarly, TAB characters should just be handled by layout; if they're not
that's a layout bug too (I'm assuming the tooltip has white-space: pre).