Comment 67 for bug 1672139

Revision history for this message
In , Standard8 (standard8) wrote :

(In reply to Romain Testard [:RT] from comment #63)
> Thanks for the ping, first I want to make sure that I correctly understand the change, my understanding is:
> 1 Open the library modal
> 2 Enter a search term in the "Search bookmarks" search bar, results appear
> 3 Right click one of the search results, context menu appears. One new entry "Open Containing Folder" is available underneath the other "Open" entries
> 4 Selecting "Open Containing Folder" opens the bookmark folder and selects it on the left hand side and selects the bookmark on the right hand side

Yes, that's the intention and what the patch currently does.

> Assuming the above is right I'd propose the following:
> - use "Open Containing Folder" for consistency with the "Downloads" section of the "Library" Window where this context menu entry already exists
> - Locate this new entry underneath other "Open" entries

That sounds good to me. One slight different to Downloads is on Mac we'll want to keep "Open Containing Folder" and not use "Show in Finder" (obviously).

Lebar, please could you update the patch for that?