Comment 42 for bug 1260788

Revision history for this message
In , Alessandro Decina (alessandro.decina) wrote :

(In reply to seppo.yli-olli from comment #33)
> (In reply to Edwin Flores [:eflores] [:edwin] from comment #29)
> > * gst_buffer_pool_config_get_video_alignment returns total rubbish, even
> > when the option GST_BUFFER_POOL_OPTION_VIDEO_ALIGNMENT is present. For now,
> > gst_video_info_align is commented out.
> I'm no expert but shouldn't you check that return value of
> gst_buffer_pool_config_get_video_alignment is TRUE before using what it
> produces? Based on quick reading of gst looks like if it doesn't return
> TRUE, it failed to parse config.

Yeah. Last weekend I rebased the patch and fixed this and a few more issues (OMTC broke the patch apparently). I will post an update soonish.