(In reply to Edwin Flores [:eflores] [:edwin] from comment #13) > Created attachment 748637 > Small fixes
Looks good, I'll integrate these fixes
> Fixes for a few small issues I had on linux: > - gst_memory_is_type doesn't exist in gstreamer <= 1.0
It was added in 1.2, what 1.x version do you have? Anyway the patch is simple enough so let's put it in for now.
> - When upstream doesn't negotiate allocator, CopyIntoImageBuffer would fail > because |mBufferPool| isn't configured
Good catch. I'm not 100% sure that passing GST_CAPS_ANY is safe there, i'll double check.
> - gst/video/gstvideo{meta,pool}.h needed to be included > - Had to force visibility in above libs to "default" to avoid link errors
Hm, I guess these have to do with the fact that you're using an older 1.x than me
(In reply to Edwin Flores [:eflores] [:edwin] from comment #13)
> Created attachment 748637
> Small fixes
Looks good, I'll integrate these fixes
> Fixes for a few small issues I had on linux:
> - gst_memory_is_type doesn't exist in gstreamer <= 1.0
It was added in 1.2, what 1.x version do you have? Anyway the patch is simple enough so let's put it in for now.
> - When upstream doesn't negotiate allocator, CopyIntoImageBuffer would fail
> because |mBufferPool| isn't configured
Good catch. I'm not 100% sure that passing GST_CAPS_ANY is safe there, i'll double check.
> - gst/video/ gstvideo{ meta,pool} .h needed to be included
> - Had to force visibility in above libs to "default" to avoid link errors
Hm, I guess these have to do with the fact that you're using an older 1.x than me