Comment 44 for bug 1228250

Revision history for this message
In , X-bugzilla (x-bugzilla) wrote :

Created attachment 193804
Backend and all new Frontend

The backend only patch did not work flawlessly on the current nightly so I
patched by hand and added a frontend.

My first GUI idea was to use 2 neested tabboxes (H/V -> N/A/C/S) but this
looked quite odd. Now I'm using popups instead of radio buttons (2*5 buttons
just took up too much space). This gives you a quick overview without consuming
more space than available.

The "Use system default" has been moved into a seperate dialog ("Advanced...").

Things that are not in this patch (I need help here!):

- I would prefer to have "[ ] Use custom settings: ___ units." instead of "[x]
Use system default" since that's what you set up here. You *activate* your
custom settings you do not *deactivate* the system's settings. My problem is
that I do not want to make the entries in the users config invalid and I do not
know how to connect the checkbox to the negated setting. Do I have to set the
checkbox in JavaScript code here or is there an better way?

- There is no help for the advanced settings dialog. (Simply remove the "Help"
button?)

- I've never created a patch that contains a new file for mozilla. Was
appending a diff agains /dev/null the correct way? Means: does the attached
patch work for you?

- Was it correct to add the new file to xpfe/components/jar.mn and
embedding/config/xulprefs.mn? pref-mousewheel.xul was there so I think it's
right.

- I did not update the defaults for all mousewheel.* preferences. (I did not
find the right place to do so) It should set up the actions in a reasonable way
(less important) and set *all* settings in the advanced settings dialog to "Use
system defaults" (and "1 unit" as inactive custom value)