Ubuntu
firefox package

  1. Bug #1197559
  2. Comment #18

Comment 18 for bug 1197559

Revision history for this message
In , Karlt (karlt) wrote :

Comment on attachment 8381157
protocol.patch

Looks good, thanks. Can you adjust the spacing a bit to match the surrounding code, as noted below, please?

>+
>+

Only one blank line, please.

>+ if ( mClass == eProtocolInfo ) {

No space after '(' or before ')'.
Only one space after "==".

>+ *_retval = nsGNOMERegistry::HandlerExists (mSchemeOrType.get());

No space before '('.