After all the work I'd done to make absolutely sure that this passed a full run of mochitests, multiple times, I checked it in. Then I discovered that it caused one of the mochi*chrome* tests to fail:
I don't know why, offhand - SetupReplacementChannel certainly does transfer the referer.
I'm very upset that I had to back this out *again* because of my own negligence. At least we know we have good test coverage of PAC-enabled network code paths, I guess.
After all the work I'd done to make absolutely sure that this passed a full run of mochitests, multiple times, I checked it in. Then I discovered that it caused one of the mochi*chrome* tests to fail:
http:// lxr.mozilla. org/seamonkey/ source/ content/ base/test/ chrome/ test_bug421622. xul
I don't know why, offhand - SetupReplacemen tChannel certainly does transfer the referer.
I'm very upset that I had to back this out *again* because of my own negligence. At least we know we have good test coverage of PAC-enabled network code paths, I guess.