Comment 23 for bug 1107850

Revision history for this message
In , Roc-ocallahan (roc-ocallahan) wrote :

Comment on attachment 673088
don't use a separate GdkWindow for MozContainer (unless necessary)

Review of attachment 673088:
-----------------------------------------------------------------

::: widget/gtk2/mozcontainer.c
@@ +196,5 @@
> tmp_list = tmp_list->next;
> }
>
> + if (gtk_widget_get_has_window (widget))
> + gdk_window_show (gtk_widget_get_window(widget));

{}

@@ +207,5 @@
>
> gtk_widget_set_mapped(widget, FALSE);
>
> + if (gtk_widget_get_has_window (widget))
> + gdk_window_hide (gtk_widget_get_window(widget));

{}

::: widget/gtk2/nsWindow.cpp
@@ +3718,5 @@
> g_signal_connect(mContainer, "drag_data_received",
> G_CALLBACK(drag_data_received_event_cb), NULL);
>
> + GtkWidget *widgets[] = { GTK_WIDGET(mContainer), mShell, nullptr };
> + for (int i = 0; widgets[i]; ++i) {

Slightly better to just use for (int i = 0; i < ArrayLength(widgets); ++i)