Please see attached a WIP patch proposal addressing all the comments by Carlos. I'm not asking r? yet, because there are a couple of things I need to check first:
- CMake build for Geoclue1 (I suspect is broken with this patch)
- CMake build for Geoclue2 (I want to give it a try anyway :)
- Providing the right desktop ID to geoclue (as it seems the dummy desktop ID included with this patch won't be good enough)
I'll try to do that on Monday, but feel free to inspect this new patch (which I tested locally and works as the previous one) if you want to
Created attachment 225475
Patch Proposal
Please see attached a WIP patch proposal addressing all the comments by Carlos. I'm not asking r? yet, because there are a couple of things I need to check first:
- CMake build for Geoclue1 (I suspect is broken with this patch)
- CMake build for Geoclue2 (I want to give it a try anyway :)
- Providing the right desktop ID to geoclue (as it seems the dummy desktop ID included with this patch won't be good enough)
I'll try to do that on Monday, but feel free to inspect this new patch (which I tested locally and works as the previous one) if you want to
Have you all a nice weekend!