Comment 22 for bug 481541

(In reply to comment #18)
> (From update of attachment 160898)
> *Always* in the foreground? Despite opinions to the contrary using strong words
> like "broken" and "useless," Bradley and I don't want tabs to *always* load in
> the foreground. And we get to win. As long as he agrees with me :). I'm r-ing
> this patch.

This bug should be renamed to "New windows that are forced to opened in tabs by
"Single Window Mode" should have their own focus rules". The current wording is
scaring away DanM. :)

What we are saying to do here for 1.0 is when using the new "Single Window
Mode", make the situations where links that would normally open in a new window
but are now forced to open via tabs NOT be controlled by the "Select tabs opened
from links" option.

You are right, the Grandmother argument doesn't fly, because the Grandmother
wouldn't even be turning on the new "Single Window Mode", and even if she just
touched that, these windows would STILL open in focus. But that isn't the bug
here, actually.

The bug here is when we turn on the recently added Single Window Mode option AND
turn off the "Select tabs opened from links" option. This new mode was
inadvertantly coded to have it's *special case* of forcing normally NEW WINDOWS
to open as NEW TABS, but STILL have them controlled by the same options as
normal tabs. This shouldn't be, because these new tabs fall into a special
case. The key here is to think of these tabs as new windows that would normally
pop up into focus. Now they are being forced to become tabs, but they should
still act in every other way as if they were new windows popping up.

The whole point from the beginning of the "Select tabs opened from links" was so
that we could middle click on links and have them open behind what we were
reading. This option is not meant to have any affect on the new "Single Window
 Mode", and it is actually detracting from it. We should not have to have one
option selected to have another option work properly, and it even just goes
against logic to have this special case fall under the control of an option not
meant for them.

Later on we can add settings to control this special case of tabs taking focus
or not. But at the moment, HARDCORE users aren't able to use the new Single
Window Mode AND have their middle clicked links open in the background, and that
is annoying.