Comment on attachment 8750107 Bug 336193 handle SIGTERM in SignalPipeWatcher then in the main thread to quit
I think this approach will work well, thanks.
SIGTERM will have no effect if Firefox gets stuck during shutdown, but I guess
that's reasonable because SIGTERM is intended to effect normal shutdown. If
Firefox shutdown is broken in such a way that it gets stuck, then other
signals are available to terminate the process. The alternative of
reinstating the previous handler after the first SIGTERM would lead to the
disadvantage that two SIGTERMs would terminate the app before shutdown
completes even if shutdown would otherwise complete as expected.
Comment on attachment 8750107
Bug 336193 handle SIGTERM in SignalPipeWatcher then in the main thread to quit
I think this approach will work well, thanks.
SIGTERM will have no effect if Firefox gets stuck during shutdown, but I guess
that's reasonable because SIGTERM is intended to effect normal shutdown. If
Firefox shutdown is broken in such a way that it gets stuck, then other
signals are available to terminate the process. The alternative of
reinstating the previous handler after the first SIGTERM would lead to the
disadvantage that two SIGTERMs would terminate the app before shutdown
completes even if shutdown would otherwise complete as expected.
> #endif
>
>+
> *aRetVal = true;
No extra newline here please.
>+ die_cb(NULL, NULL);
nullptr /developer. mozilla. org/en- US/docs/ Mozilla/ Developer_ guide/Coding_ Style#CC_ practices
https:/
>+namespace { er(const uint8_t aRecvSig) {
>+ void termSignalHandl
Please use static instead of the anonymous namespace. /developer. mozilla. org/en- US/docs/ Mozilla/ Developer_ guide/Coding_ Style#Anonymous _namespaces
https:/
Gecko capitalizes the first letter of C++ method names (distinct from variable
names).
>+ RefPtr<QuitTask> task = new QuitTask(); inThread( task);
>+ NS_DispatchToMa
NS_DispatchToMa inThread( task.forget( )); to save unnecessary ref count toggle.
Please also remove the trailing whitespace in this patch.
Some changes will be needed to merge with changes for bug 1372405. unction( ) may be useful.
NS_NewRunnableF