Review of attachment 657902:
-----------------------------------------------------------------
The net effect of this is going to mean the socket thread stays constant even when offline/online events occur. I think that's a really good thing and it will eliminate a few classes of bugs.
r+ contingent on these small items and answers to comment 40.
you need at least push/pop. Please comment that this is necessary because the mochitest proxy runs n localhost and localhost is now reachable even when offline.
Comment on attachment 657902
Unbitrot
Review of attachment 657902: ------- ------- ------- ------- ------- ------- ------- ------- --
-------
The net effect of this is going to mean the socket thread stays constant even when offline/online events occur. I think that's a really good thing and it will eliminate a few classes of bugs.
r+ contingent on these small items and answers to comment 40.
::: browser/ base/content/ test/browser_ bug435325. js Function( function( ) { prefs.setIntPre f("network. proxy.type" , 2);
@@ +40,5 @@
> finish();
> }
>
> registerCleanup
> + Services.
you need at least push/pop. Please comment that this is necessary because the mochitest proxy runs n localhost and localhost is now reachable even when offline.
::: netwerk/ base/src/ nsSocketTranspo rtService2. cpp ortService: :Reset( bool aGuardLocals)
@@ +684,5 @@
> +void
> +nsSocketTransp
> +{
> + // detach any sockets
> + PRInt32 i;
you've reintroduced PRint types.. need to scrub for those.
@@ +686,5 @@
> +{
> + // detach any sockets
> + PRInt32 i;
> + bool isGuarded;
> + for (i=mActiveCount-1; i>=0; --i) {
I know its copy and paste, but fix it up to
for (i = mActiveCouint -1; i >= 0; --i)
@@ +693,5 @@ i].mHandler- >IsLocal( &isGuarded) ; mActiveList, &mActiveList[i]);
> + mActiveList[
> + if (!isGuarded)
> + DetachSocket(
> + }
> + for (i=mIdleCount-1; i>=0; --i) {
again, fix the spacing
::: toolkit/ components/ places/ tests/browser/ browser_ bug680727. js selectedTab = gBrowser.addTab(); prefs.setIntPre f("network. proxy.type" , 0);
@@ +17,5 @@
> gBrowser.
>
> + // Bypass proxy temporarily, (local is available in offline, see bug 87717)
> + Services.
> +
same comments from bug435325
::: toolkit/ mozapps/ extensions/ test/xpinstall/ browser_ offline. js progress( addon, value, maxValue) { prefs.setIntPre f("network. proxy.type" , 0);
@@ +16,5 @@
> }
>
> function download_
> try {
> + Services.
same comments from bug 435325