Comment 12 for bug 288236

Revision history for this message
In , Myk (myk) wrote :

Created an attachment (id=305662)
patch v4: updated to tip

This patch is identical to patch v3, it's just been updated to the tip, where the fix for bug 416208 already made the necessary changes to nsIContentPrefService.idl and nsContentPrefService.js.

> I still think this code should be in the service so that sanitize.js doesn't
> need to know about the database - compare and contrast with other services
>
> cacheService.evictEntries(...)
> cookieMgr.removeAll()
> globalHistory.removeAllPages();
> ...

That's a good point, although those methods remove all entries rather than selected ones. But we could always call the method something that made it clear it was only deleting grouped prefs, f.e. removeGroupedPrefs or the like to the service. I'm amenable to this approach. Reviewer, what say you?