Comment 29 for bug 288111

Revision history for this message
In , Ehsan-mozilla (ehsan-mozilla) wrote :

Created attachment 364717
Resize & Reorder Patch

Finally I figured that the reordering of tree columns is handled inside tree.xml. This patch fixes the reordering issue in addition to what the previous patch solved for the resize issue.

The logic to fix the reordering is very simple: start looking up the column from end to start in RTL mode (which makes the lookup order to be from physical left to physical right, no matter what the direction of the tree is).

With this change, the only things that were needed were to make sure that "before" and "after" are specified physically (i.e., being equivalent to physical left and right), and adjusting a bunch of CSS in order to draw the drop indicator line correctly for RTL mode.

Requesting r+sr from roc on the layout part, and r from Neil on the toolkit part.