Comment 11 for bug 269188

Revision history for this message
In , Wan-Teh Chang (wtc-google) wrote :

Comment on attachment 339195
Patch

This fix is good. We should make this change unconditionally,
rather than with #ifdef LINUX. Perhaps OpenDevRandom and
fdDevRandom should be renamed accordingly.

I'm more concerned about the code that's calling PR_GetRandomNoise.
The output of PR_GetRandomNoise should only be used to seed a
pseudorandom number generator (PRNG). PR_GetRandomNoise must not
be used as a PRNG directly.