Comment 35 for bug 225379

Revision history for this message
In , Bzbarsky (bzbarsky) wrote :

Looks like the basic issue is that imgRequestProxy::IsPending is not implemented. It should be. In particular, it should be pending if the underlying channel is pending. That is, pages that have a not-fully-loaded image on them should not go into bfcache....

I'll take a shot at fixing this in a few weeks once I have a tree again, if no one else gets there first.

At least that covers the bug as filed. The tab-closing thing I'm not sure about. That shouldn't be putting things into bfcache.

What would help most here is if someone creates a testcase that makes it as easy as possible to tell whether the connection got restarted or not. Ideal would be a server that for each connection pushes out a bunch of identical frames with each one containing a unique id the server assigns to that connection. That way, the id should change on pageload and then back, right? If someone is willing to set that up, that would save me a ton of time trying to test fixes... If someone is willing to create a mochitest or something along those lines, that would be even more helpful.