I agree that comparisons like if (NS_ERROR_IN_PROGRESS == rv) are a good idea, as they avoid typos and accidental assignments, it's an old trick, I personally wouldn't reject such code.
I agree that comparisons like IN_PROGRESS == rv)
if (NS_ERROR_
are a good idea, as they avoid typos and accidental assignments, it's an old trick, I personally wouldn't reject such code.