ctrl+shift+pg.up/dn does not move tabs

[David Prieto]

Binary package hint: firefox-3.0

I have noticed that the ctrl+shift+pg.up/dn key combination does not move tabs left or right in firefox, as it does in every other app in ubuntu. Any chance of this being fixed?

[David Prieto (frandavid100-gmail)]

Binary package hint: firefox-3.0

I have noticed that the ctrl+shift+pg.up/dn key combination does not move tabs left or right in firefox, as it does in every other app in ubuntu. Any chance of this being fixed?

[Alexander Sack (asac)]

indeed. this could be improved to better match the gnome desktop experience. can someone look if there is a bug in bugzilla.mozilla.org for this already?

[Rolf Leggewie (r0lf)]

It does so now. Can we close this?

[David Prieto (frandavid100-gmail)]

I'm trying RC1 right now and it doesn't.

[Rolf Leggewie (r0lf)]

RC1? That's not from a ubuntu package, is it?

[Rolf Leggewie (r0lf)]

Ctrl+*Shift*+PgUp, right? I was trying out Ctrl+PgUp which switched to the next tab (also nice to know, thanks)

Reconfirming

[David Prieto (frandavid100-gmail)]

Yes, Ctrl+PgUp changes tabs but Ctrl+*Shift*+PgUp moves them left and right -well, not in Firefox, but it should-.

About RC1, it was uploaded to the repos earlier today.

[Micah Gersten (micahg)]

Thank you for your bug report. This bug has been reported to the developers of the software. You can track it and make comments at:
https://bugzilla.mozilla.org/show_bug.cgi?id=423734

[Mozilla-bugs-micahscomputing (mozilla-bugs-micahscomputing)]

Ubuntu Bug:
https://bugs.launchpad.net/bugs/192092

Duplicates:
Bug 423734
Bug 391084

Does not work in Firefox 3.5.

[Micah Gersten (micahg)]

Found original upstream bug.

[Micah Gersten (micahg)]

Moving tracking to Firefox 3.5

[Micah Gersten (micahg)]

Firefox 3.0 is only receiving Security Updates and major bug fixes at this point.

[Tony Chang (tony-ponderer)]

*** Bug 391084 has been marked as a duplicate of this bug. ***

[Tony Chang (tony-ponderer)]

*** Bug 423734 has been marked as a duplicate of this bug. ***

[Gavin Sharp (gavin-sharp)]

*** Bug 702960 has been marked as a duplicate of this bug. ***

[Marius Gedminas (mgedmin)]

Created attachment 689087
patch version 2

Version 2 of the patch, with style changes as requested by Gavin in comments of bug 702960.

Tested, works for me.

One thing I hadn't noticed before: moveTabForward/Backward leaves keyboard focus on the tab itself, which is something I didn't expect. This explains why I had occasional difficulties scrolling web pages with Space or PgUp/PgDown lately -- keyboard focus was in the wrong place, and I didn't notice. Any ideas how to avoid that focus change?

[Dao (dao)]

(In reply to Marius Gedminas from comment #5)
> One thing I hadn't noticed before: moveTabForward/Backward leaves keyboard
> focus on the tab itself, which is something I didn't expect. This explains
> why I had occasional difficulties scrolling web pages with Space or
> PgUp/PgDown lately -- keyboard focus was in the wrong place, and I didn't
> notice. Any ideas how to avoid that focus change?

You can remove the focus change from the moveTabBackward, moveTabForward, moveTabToStart and moveTabToEnd methods and do it directly in the keypress handler where needed.

[Gavin Sharp (gavin-sharp)]

It looks like bug 822068 is also touching this code.

[Ithinc (ithinc)]

So ctrl-shift-home/end should move current tab to start/end?

[Ithinc (ithinc)]

Noticed that these key combinations have been used in Caret Browsing mode.

[Gavin Sharp (gavin-sharp)]

(In reply to ithinc from comment #9)
> Noticed that these key combinations have been used in Caret Browsing mode.

Do you have a pointer to the code?

[Gavin Sharp (gavin-sharp)]

Comment on attachment 689087
patch version 2

Code-wise, this looks good. I think the only suggestions I would make is that we should probably limit this behavior to Linux somehow (probably by using an #ifdef XP_GNOME like the one in browser-sets.inc).

I don't know the answers to ithinc's concerns, though (about the desired behavior for ctrl+shift+home/end, and possible conflict with other shortcuts) - we should sort that out before landing this.

[Ithinc (ithinc)]

(In reply to :Gavin Sharp (use <email address hidden> for email) from comment #10)
> (In reply to ithinc from comment #9)
> > Noticed that these key combinations have been used in Caret Browsing mode.
>
> Do you have a pointer to the code?

I overlooked it. ctrl-shift-home/end are used but ctrl-shift-pageup/down not.

[Gavin Sharp (gavin-sharp)]

OK, let's do this then!

Thanks again for the patch, Marius.

[Ryanvm (ryanvm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d16a92e1a41

[Ed Morley (edmorley)]

https://hg.mozilla.org/mozilla-central/rev/0d16a92e1a41

[Cornel-ionce (cornel-ionce)]

Working on Firefox Nightly.
User Agent: Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20130129 Firefox/21.0
Build ID: 20130129030851.

Marking as verified fixed.

[Adolfo Jayme Barrientos (fitojb)]

The fix will be available in Firefox 21.

[Tabutils (tabutils)]

I'm curious about why this was not implemented via xul overlay.

[Dao (dao)]

(In reply to ithinc from comment #17)
> I'm curious about why this was not implemented via xul overlay.

There's not a great chance that you'll get a reply here. Feel free to file a new bug and propose a patch.